Re: [Qemu-devel] [PATCH v18 04/29] !fixup target/rx: CPU definition

2019-06-10 Thread Igor Mammedov
On Fri, 7 Jun 2019 20:06:12 +0200 Philippe Mathieu-Daudé wrote: > On 6/7/19 8:02 PM, Eric Blake wrote: > > On 6/7/19 10:37 AM, Philippe Mathieu-Daudé wrote: > >> Rename macros. > > > > Why is this marked '!fixup' in the subject instead of just merging the > > patches directly? > > Since a

Re: [Qemu-devel] [PATCH v18 04/29] !fixup target/rx: CPU definition

2019-06-07 Thread Eric Blake
On 6/7/19 10:37 AM, Philippe Mathieu-Daudé wrote: > Rename macros. Why is this marked '!fixup' in the subject instead of just merging the patches directly? > > Signed-off-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > target/rx/cpu.c | 22 ++ > targe

Re: [Qemu-devel] [PATCH v18 04/29] !fixup target/rx: CPU definition

2019-06-07 Thread Philippe Mathieu-Daudé
On 6/7/19 8:02 PM, Eric Blake wrote: > On 6/7/19 10:37 AM, Philippe Mathieu-Daudé wrote: >> Rename macros. > > Why is this marked '!fixup' in the subject instead of just merging the > patches directly? Since all the series is reviewed/tested and Igor asked to amend a fixup but we are having hard

[Qemu-devel] [PATCH v18 04/29] !fixup target/rx: CPU definition

2019-06-07 Thread Philippe Mathieu-Daudé
Rename macros. Signed-off-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/rx/cpu.c | 22 ++ target/rx/cpu.h | 12 ++-- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 4b96f2e463..3c434675