Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson wrote: > An obvious typo in the mnemonic here. > > Signed-off-by: Richard Henderson > --- > target-tilegx/opcode_tilegx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-26 Thread Chris Metcalf
I have queued both this and the 06/33 patch in the linux-tile tree as a single patch for the kernel when the 4.3 merge window opens, with Richard's Reported-By. Thanks! Both of these appear to be cut-and-paste errors from the tilepro versions of the files. On 08/24/2015 12:17 PM, Richard Hender

Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-24 Thread Richard Henderson
On 08/24/2015 09:29 AM, Peter Maydell wrote: - LWNA_ADD_IMM8_OPCODE_X1 = 21, + LDNA_ADD_IMM8_OPCODE_X1 = 21, MFSPR_IMM8_OPCODE_X1 = 22, MF_UNARY_OPCODE_X1 = 31, MM_BF_OPCODE_X0 = 7, -- 2.4.3 Should we feed this fix and the one in patch 6 back to the kernel? Probably. r~

[Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-24 Thread Richard Henderson
An obvious typo in the mnemonic here. Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tilegx/opcode_tilegx.h b/target-tilegx/opcode_tilegx.h index 3b8bf4f..989436d 100644 --- a/target-tilegx/opcode_tile

Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-24 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson wrote: > An obvious typo in the mnemonic here. > > Signed-off-by: Richard Henderson > --- > target-tilegx/opcode_tilegx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-tilegx/opcode_tilegx.h b/target-tilegx/opcode_ti