Re: [Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-20 Thread Jeff Cody
On Thu, Feb 20, 2014 at 04:28:56PM +0800, Fam Zheng wrote: > On Thu, 02/20 00:08, Jeff Cody wrote: > > On Thu, Feb 20, 2014 at 01:01:38PM +0800, Fam Zheng wrote: > > > On Wed, 02/19 16:17, Jeff Cody wrote: > > > > On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote: > > > > > This makes use o

Re: [Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-20 Thread Fam Zheng
On Thu, 02/20 00:08, Jeff Cody wrote: > On Thu, Feb 20, 2014 at 01:01:38PM +0800, Fam Zheng wrote: > > On Wed, 02/19 16:17, Jeff Cody wrote: > > > On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote: > > > > This makes use of op_blocker and blocks all the operations except for > > > > commit

Re: [Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-19 Thread Jeff Cody
On Thu, Feb 20, 2014 at 01:01:38PM +0800, Fam Zheng wrote: > On Wed, 02/19 16:17, Jeff Cody wrote: > > On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote: > > > This makes use of op_blocker and blocks all the operations except for > > > commit target, on each BlockDriverState->backing_hd. >

Re: [Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-19 Thread Fam Zheng
On Wed, 02/19 16:17, Jeff Cody wrote: > On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote: > > This makes use of op_blocker and blocks all the operations except for > > commit target, on each BlockDriverState->backing_hd. > > > > The asserts for op_blocker in bdrv_swap are removed because

Re: [Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-19 Thread Jeff Cody
On Wed, Feb 19, 2014 at 09:42:23PM +0800, Fam Zheng wrote: > This makes use of op_blocker and blocks all the operations except for > commit target, on each BlockDriverState->backing_hd. > > The asserts for op_blocker in bdrv_swap are removed because with this > change, the target of block commit h

Re: [Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-19 Thread Benoît Canet
The Wednesday 19 Feb 2014 à 21:42:23 (+0800), Fam Zheng wrote : > This makes use of op_blocker and blocks all the operations except for > commit target, on each BlockDriverState->backing_hd. > > The asserts for op_blocker in bdrv_swap are removed because with this > change, the target of block com

[Qemu-devel] [PATCH v14 06/14] block: Add backing_blocker in BlockDriverState

2014-02-19 Thread Fam Zheng
This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState->backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so the assertion is not