Re: [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-15 Thread Richard Henderson
On 07/14/2017 09:56 PM, Lluís Vilanova wrote: Another possibility is is_jmp = DISAS_TOO_MANY, and exit the translation loop after the breakpoint check only for is_jmp > DISAS_TOO_MANY. That allows all of the DISAS_TARGET_N values to exit as well. After a quick check, I see that arm uses both (

Re: [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-15 Thread Lluís Vilanova
Richard Henderson writes: > On 07/14/2017 07:26 AM, Richard Henderson wrote: >> On 07/13/2017 11:26 PM, Lluís Vilanova wrote: >>> Incrementally paves the way towards using the generic instruction >>> translation >>> loop. >>> >>> Signed-off-by: Lluís Vilanova >>> Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-15 Thread Lluís Vilanova
Richard Henderson writes: > On 07/13/2017 11:26 PM, Lluís Vilanova wrote: >> Incrementally paves the way towards using the generic instruction translation >> loop. >> >> Signed-off-by: Lluís Vilanova >> Reviewed-by: Richard Henderson >> --- >> target/arm/translate.c | 53 >> +

Re: [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-14 Thread Richard Henderson
On 07/14/2017 07:26 AM, Richard Henderson wrote: On 07/13/2017 11:26 PM, Lluís Vilanova wrote: Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- target/arm/translate.c | 53 +

Re: [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-14 Thread Richard Henderson
On 07/13/2017 11:26 PM, Lluís Vilanova wrote: Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- target/arm/translate.c | 53 +++- 1 file changed,

[Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-14 Thread Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- target/arm/translate.c | 53 +++- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/ta