Re: [Qemu-devel] [PATCH v12 26/36] qapi: Change munging of CamelCase enum values

2015-11-18 Thread Markus Armbruster
Eric Blake writes: > When munging enum values, the fact that we were passing the entire > prefix + value through camel_to_upper() meant that enum values > spelled with CamelCase could be turned into CAMEL_CASE. However, > this provides a potential collision (both OneTwo and One-Two would > munge

[Qemu-devel] [PATCH v12 26/36] qapi: Change munging of CamelCase enum values

2015-11-18 Thread Eric Blake
When munging enum values, the fact that we were passing the entire prefix + value through camel_to_upper() meant that enum values spelled with CamelCase could be turned into CAMEL_CASE. However, this provides a potential collision (both OneTwo and One-Two would munge into ONE_TWO) for enum types,