Re: [Qemu-devel] [PATCH v12 2/5] intc/gic: Extract some reusable vGIC code

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 07:54, Pavel Fedin wrote: > Hello! > >> > + >> > +#define kvm_gicd_access(s, offset, cpu, val, write) \ >> > +kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_DIST_REGS, \ >> > + KVM_VGIC_ATTR(offset, cpu), val, write) >> > + >> > +#define kvm_gicc

Re: [Qemu-devel] [PATCH v12 2/5] intc/gic: Extract some reusable vGIC code

2015-09-03 Thread Pavel Fedin
Hello! > > + > > +#define kvm_gicd_access(s, offset, cpu, val, write) \ > > +kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_DIST_REGS, \ > > + KVM_VGIC_ATTR(offset, cpu), val, write) > > + > > +#define kvm_gicc_access(s, offset, cpu, val, write) \ > > +kvm_device_a

Re: [Qemu-devel] [PATCH v12 2/5] intc/gic: Extract some reusable vGIC code

2015-09-03 Thread Peter Maydell
On 26 August 2015 at 11:28, Pavel Fedin wrote: > Some functions previously used only by vGICv2 are useful also for vGICv3 > implementation. Untie them from GICState and make accessible from within > other modules: > - kvm_arm_gic_set_irq() > - kvm_gic_supports_attr() - moved to common code and ren

[Qemu-devel] [PATCH v12 2/5] intc/gic: Extract some reusable vGIC code

2015-08-26 Thread Pavel Fedin
Some functions previously used only by vGICv2 are useful also for vGICv3 implementation. Untie them from GICState and make accessible from within other modules: - kvm_arm_gic_set_irq() - kvm_gic_supports_attr() - moved to common code and renamed to kvm_device_check_attr() - kvm_gic_access() - tur