Re: [Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-14 Thread Fam Zheng
On Sun, 02/14 22:49, Jeff Cody wrote: > On Feb 14, 2016 21:19, "Fam Zheng" wrote: > > > > On Mon, 02/08 13:54, Max Reitz wrote: > > > On 07.02.2016 13:46, Fam Zheng wrote: > > > > On Sat, 02/06 14:24, Max Reitz wrote: > > > >> On 05.02.2016 03:00, Fam Zheng wrote: > > > >>> The "pnum < nb_sectors"

Re: [Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-14 Thread Jeff Cody
On Feb 14, 2016 21:19, "Fam Zheng" wrote: > > On Mon, 02/08 13:54, Max Reitz wrote: > > On 07.02.2016 13:46, Fam Zheng wrote: > > > On Sat, 02/06 14:24, Max Reitz wrote: > > >> On 05.02.2016 03:00, Fam Zheng wrote: > > >>> The "pnum < nb_sectors" condition in deciding whether to actually copy > >

Re: [Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-14 Thread Fam Zheng
On Mon, 02/08 13:54, Max Reitz wrote: > On 07.02.2016 13:46, Fam Zheng wrote: > > On Sat, 02/06 14:24, Max Reitz wrote: > >> On 05.02.2016 03:00, Fam Zheng wrote: > >>> The "pnum < nb_sectors" condition in deciding whether to actually copy > >>> data is unnecessarily strict, and the qiov initializa

Re: [Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-08 Thread Max Reitz
On 07.02.2016 13:46, Fam Zheng wrote: > On Sat, 02/06 14:24, Max Reitz wrote: >> On 05.02.2016 03:00, Fam Zheng wrote: >>> The "pnum < nb_sectors" condition in deciding whether to actually copy >>> data is unnecessarily strict, and the qiov initialization is >>> unnecessarily for bdrv_aio_write_zer

Re: [Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-07 Thread Fam Zheng
On Sat, 02/06 14:24, Max Reitz wrote: > On 05.02.2016 03:00, Fam Zheng wrote: > > The "pnum < nb_sectors" condition in deciding whether to actually copy > > data is unnecessarily strict, and the qiov initialization is > > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > > > Rewrit

Re: [Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-06 Thread Max Reitz
On 05.02.2016 03:00, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > The out

[Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-04 Thread Fam Zheng
The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. The output of iotests 109 is updated because we now report