Re: [Qemu-devel] [PATCH v12 03/14] qcow2: Optimize bdrv_make_empty()

2014-10-11 Thread Max Reitz
Am 10.10.2014 um 14:32 schrieb Eric Blake: On 08/26/2014 03:36 PM, Max Reitz wrote: bdrv_make_empty() is currently only called if the current image represents an external snapshot that has been committed to its base image; it is therefore unlikely to have internal snapshots. In this case, bdrv_m

Re: [Qemu-devel] [PATCH v12 03/14] qcow2: Optimize bdrv_make_empty()

2014-10-10 Thread Eric Blake
On 10/10/2014 06:32 AM, Eric Blake wrote: > On 08/26/2014 03:36 PM, Max Reitz wrote: >> bdrv_make_empty() is currently only called if the current image >> represents an external snapshot that has been committed to its base >> image; it is therefore unlikely to have internal snapshots. In this >> ca

Re: [Qemu-devel] [PATCH v12 03/14] qcow2: Optimize bdrv_make_empty()

2014-10-10 Thread Eric Blake
On 08/26/2014 03:36 PM, Max Reitz wrote: > bdrv_make_empty() is currently only called if the current image > represents an external snapshot that has been committed to its base > image; it is therefore unlikely to have internal snapshots. In this > case, bdrv_make_empty() can be greatly sped up by

[Qemu-devel] [PATCH v12 03/14] qcow2: Optimize bdrv_make_empty()

2014-08-26 Thread Max Reitz
bdrv_make_empty() is currently only called if the current image represents an external snapshot that has been committed to its base image; it is therefore unlikely to have internal snapshots. In this case, bdrv_make_empty() can be greatly sped up by emptying the L1 and refcount table (while having