Peter Maydell wrote:
On 11 December 2013 08:08, liguang wrote:
+static void aw_a10_pic_set_irq(void *opaque, int irq, int level)
+{
+AwA10PICState *s = opaque;
+
+if (level) {
+set_bit(irq%32, (void *)&s->irq_pending[irq/32]);
The % and / operators here should have sp
On 11 December 2013 08:08, liguang wrote:
> +static void aw_a10_pic_set_irq(void *opaque, int irq, int level)
> +{
> +AwA10PICState *s = opaque;
> +
> +if (level) {
> +set_bit(irq%32, (void *)&s->irq_pending[irq/32]);
The % and / operators here should have spaces round them.
> +
On 11 December 2013 08:27, Peter Crosthwaite
wrote:
> Reduces reliance on qemu_set_irq implementation
> (ideally someone converts that API to accept bool).
I have a feeling we have some users of that API which use it
to pass an arbitrary integer value around, not just for a
true/false value.
An
On Wed, Dec 11, 2013 at 6:08 PM, liguang wrote:
> Signed-off-by: liguang
> ---
> default-configs/arm-softmmu.mak |1 +
> hw/intc/Makefile.objs |1 +
> hw/intc/allwinner-a10-pic.c | 200
> +++
> include/hw/intc/allwinner-a10-pic.
Signed-off-by: liguang
---
default-configs/arm-softmmu.mak |1 +
hw/intc/Makefile.objs |1 +
hw/intc/allwinner-a10-pic.c | 200 +++
include/hw/intc/allwinner-a10-pic.h | 40 +++
4 files changed, 242 insertions(+), 0 deletion
