Re: [Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/27/2015 10:01 AM, Markus Armbruster wrote: >> Eric Blake writes: > >> I went through all commit messages and tweaked around occurences of QMP. >> I pushed the result to qapi-next; please have a look. > > Commit 2858a50 (Prefer typesafe upcasts...) on that branch has to

Re: [Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-27 Thread Eric Blake
On 10/27/2015 10:01 AM, Markus Armbruster wrote: > Eric Blake writes: > I went through all commit messages and tweaked around occurences of QMP. > I pushed the result to qapi-next; please have a look. Commit 2858a50 (Prefer typesafe upcasts...) on that branch has too much text (you pasted in cor

Re: [Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/26/2015 04:35 PM, Eric Blake wrote: >> We have two issues with our qapi union layout: >> 1) Even though the QMP wire format spells the tag 'type', the >> C code spells it 'kind', requiring some hacks in the generator. >> 2) The C struct uses an anonymous union, which pl

Re: [Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-27 Thread Eric Blake
On 10/26/2015 04:35 PM, Eric Blake wrote: > We have two issues with our qapi union layout: > 1) Even though the QMP wire format spells the tag 'type', the > C code spells it 'kind', requiring some hacks in the generator. > 2) The C struct uses an anonymous union, which places all tag > values in th

[Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le