Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-02-01 Thread Evgeny Voevodin
On 02/02/2012 09:20 AM, Evgeny Voevodin wrote: Thanks for the remarks. It seems that our patches will not be applied until Anthony's patches come to upstream. If so, we will fix CamelCases and spaces, rebase and produce v12. Could someone, please, advise a better/faster way: wait until Anthony's

Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-02-01 Thread Evgeny Voevodin
On 02/01/2012 11:21 PM, Andreas Färber wrote: The formatting looks interesting here... copied from an external header? Copied from HW specification :) -- Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevo...@samsung.com

Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-02-01 Thread Evgeny Voevodin
On 02/01/2012 11:21 PM, Andreas Färber wrote: +static const VMStateDescription VMState_Exynos4210IRQGate = { Not CamelCase ;) But seriously, I really think review makes more sense when the patches can actually be applied unmodified. Out patches could be applied to current master without modi

Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-02-01 Thread Andreas Färber
Am 30.01.2012 08:38, schrieb Evgeny Voevodin: > Signed-off-by: Evgeny Voevodin > --- > diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c > new file mode 100644 > index 000..4d41a1a > --- /dev/null > +++ b/hw/exynos4210_combiner.c > +static const VMStateDescription VMState_Exyn

Re: [Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-02-01 Thread Peter Maydell
On 30 January 2012 07:38, Evgeny Voevodin wrote: > Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH v11 1/9] ARM: exynos4210: IRQ subsystem support.

2012-01-29 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- Makefile.target |1 + hw/exynos4210.h | 82 hw/exynos4210_combiner.c | 481 ++ hw/exynos4210_gic.c | 452 +++ 4 files changed, 1016 insert