Re: [Qemu-devel] [PATCH v10 03/13] scripts: Add archive-source.sh

2017-09-21 Thread Eric Blake
On 09/20/2017 07:45 PM, Fam Zheng wrote: >> >> has a flaw that $? is no longer what you want, at which point you would >> have to introduce a temporary variable. But we're using bash, so you >> can instead write this as: >> >> if test "${PIPESTATUS[@]}" != "0 0"; then > > Hmm, with exactly this l

Re: [Qemu-devel] [PATCH v10 03/13] scripts: Add archive-source.sh

2017-09-20 Thread Fam Zheng
On Wed, 09/20 08:20, Eric Blake wrote: > On 09/19/2017 10:25 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 51 > > +++ > > 1 file changed, 51 insertions(+) > > create mode 100755 scripts/archive-source.sh >

Re: [Qemu-devel] [PATCH v10 03/13] scripts: Add archive-source.sh

2017-09-20 Thread Fam Zheng
On Wed, 09/20 08:20, Eric Blake wrote: > On 09/19/2017 10:25 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 51 > > +++ > > 1 file changed, 51 insertions(+) > > create mode 100755 scripts/archive-source.sh >

Re: [Qemu-devel] [PATCH v10 03/13] scripts: Add archive-source.sh

2017-09-20 Thread Eric Blake
On 09/19/2017 10:25 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > scripts/archive-source.sh | 51 > +++ > 1 file changed, 51 insertions(+) > create mode 100755 scripts/archive-source.sh > > + > +if test -n "$submodules"; then > +{ > +

[Qemu-devel] [PATCH v10 03/13] scripts: Add archive-source.sh

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 51 +++ 1 file changed, 51 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new file mode 100755 index 00..81