Re: [Qemu-devel] [PATCH v10 02/26] x86-iommu: provide x86_iommu_get_default

2016-07-04 Thread Peter Xu
On Mon, Jul 04, 2016 at 06:17:47PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 21, 2016 at 03:47:30PM +0800, Peter Xu wrote: > > Instead of searching the device tree every time, one static variable is > > declared for the default system x86 IOMMU device. Also, some VT-d > > macros are replaced

Re: [Qemu-devel] [PATCH v10 02/26] x86-iommu: provide x86_iommu_get_default

2016-07-04 Thread Peter Xu
On Mon, Jul 04, 2016 at 06:16:08PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 21, 2016 at 03:47:30PM +0800, Peter Xu wrote: > > Instead of searching the device tree every time, one static variable is > > declared for the default system x86 IOMMU device. Also, some VT-d > > macros are replaced

Re: [Qemu-devel] [PATCH v10 02/26] x86-iommu: provide x86_iommu_get_default

2016-07-04 Thread Michael S. Tsirkin
On Tue, Jun 21, 2016 at 03:47:30PM +0800, Peter Xu wrote: > Instead of searching the device tree every time, one static variable is > declared for the default system x86 IOMMU device. Also, some VT-d > macros are replaced by x86 ones. In the future pls don't mix unrelated changes in same patch li

Re: [Qemu-devel] [PATCH v10 02/26] x86-iommu: provide x86_iommu_get_default

2016-07-04 Thread Michael S. Tsirkin
On Tue, Jun 21, 2016 at 03:47:30PM +0800, Peter Xu wrote: > Instead of searching the device tree every time, one static variable is > declared for the default system x86 IOMMU device. Also, some VT-d > macros are replaced by x86 ones. > > Signed-off-by: Peter Xu I think it's cleaner to just use

[Qemu-devel] [PATCH v10 02/26] x86-iommu: provide x86_iommu_get_default

2016-06-21 Thread Peter Xu
Instead of searching the device tree every time, one static variable is declared for the default system x86 IOMMU device. Also, some VT-d macros are replaced by x86 ones. Signed-off-by: Peter Xu --- hw/i386/acpi-build.c | 9 ++--- hw/i386/intel_iommu.c | 9 ++--- hw/i