Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-18 Thread Richard Henderson
On 9/18/19 4:33 AM, Alex Bennée wrote: >>> Ahh I was going to hardcode the arm madd instruction in as the builtin >>> wasn't expanding. I tried setting -march in the CFLAGS but that didn't >>> trigger it either on my buster arm-hf compiler. Any ideas how to get the >>> compiler to do the right thin

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-18 Thread Alex Bennée
Richard Henderson writes: > On 9/17/19 5:00 PM, Alex Bennée wrote: +add_f32_const(0x8p-152); +add_f32_const(0x8p-152); +add_f32_const(0x8p-152); >>> >>> Why are you adding 3 of the same? >> >> To replicate the 1841491 test case where the same number is used for >> a/b

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-17 Thread Richard Henderson
On 9/17/19 5:00 PM, Alex Bennée wrote: >>> +add_f32_const(0x8p-152); >>> +add_f32_const(0x8p-152); >>> +add_f32_const(0x8p-152); >> >> Why are you adding 3 of the same? > > To replicate the 1841491 test case where the same number is used for > a/b/c Then we really ought to be more exp

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-17 Thread Alex Bennée
Richard Henderson writes: > On 9/17/19 2:41 PM, Alex Bennée wrote: >> +/* From https://bugs.launchpad.net/qemu/+bug/1841491 */ >> +add_f32_const(0x1.cp-1022); >> +add_f32_const(0x1.1p-1); >> +add_f32_const(0x0.1p-1022); > > These three constan

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-17 Thread Richard Henderson
On 9/17/19 2:41 PM, Alex Bennée wrote: > +/* From https://bugs.launchpad.net/qemu/+bug/1841491 */ > +add_f32_const(0x1.cp-1022); > +add_f32_const(0x1.1p-1); > +add_f32_const(0x0.1p-1022); These three constants do not fit in float32. > +add_f