Re: [Qemu-devel] [PATCH v1 6/9] qapi: rewrite string-input-visitor

2018-11-19 Thread David Hildenbrand
On 19.11.18 20:51, Markus Armbruster wrote: > Copying Igor and Eduardo for a hostmem.c bug. Search for "core dumped". > > David Hildenbrand writes: > Tests have to be fixed up: - Two BUGs were hardcoded that are fixed now - The string-input-visitor now actually returns a par

Re: [Qemu-devel] [PATCH v1 6/9] qapi: rewrite string-input-visitor

2018-11-19 Thread Markus Armbruster
Copying Igor and Eduardo for a hostmem.c bug. Search for "core dumped". David Hildenbrand writes: >>> >>> Tests have to be fixed up: >>> - Two BUGs were hardcoded that are fixed now >>> - The string-input-visitor now actually returns a parsed list and not >>> an ordered set. >> >> I'd expect

Re: [Qemu-devel] [PATCH v1 6/9] qapi: rewrite string-input-visitor

2018-11-19 Thread David Hildenbrand
>> >> Tests have to be fixed up: >> - Two BUGs were hardcoded that are fixed now >> - The string-input-visitor now actually returns a parsed list and not >> an ordered set. > > I'd expect this to necessitate an update of callers that expect a set, but... > >> Signed-off-by: David Hildenbrand >

Re: [Qemu-devel] [PATCH v1 6/9] qapi: rewrite string-input-visitor

2018-11-16 Thread Markus Armbruster
David Hildenbrand writes: > The input visitor has some problems right now, especially > - unsigned type "Range" is used to process signed ranges, resulting in > inconsistent behavior and ugly/magical code > - uint64_t are parsed like int64_t, so big uint64_t values are not > supported and err

[Qemu-devel] [PATCH v1 6/9] qapi: rewrite string-input-visitor

2018-11-15 Thread David Hildenbrand
The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in inconsistent behavior and ugly/magical code - uint64_t are parsed like int64_t, so big uint64_t values are not supported and error messages are misleading - lists/ran