Re: [Qemu-devel] [PATCH v1 6/6] arm: a9mpcore: Coreify the SCU

2013-02-19 Thread Peter Crosthwaite
On Tue, Feb 19, 2013 at 4:49 AM, Peter Maydell wrote: > On 8 February 2013 04:03, Peter Crosthwaite > wrote: >> Split the SCU in a9mpcore out into its own object definition. mpcore is now >> just a container for the mpcore components. > > Good idea. > >> --- a/hw/a9mpcore.c >> +++ b/hw/a9mpcore.c

Re: [Qemu-devel] [PATCH v1 6/6] arm: a9mpcore: Coreify the SCU

2013-02-19 Thread Peter Maydell
On 19 February 2013 23:54, Peter Crosthwaite wrote: > On Tue, Feb 19, 2013 at 6:19 AM, Andreas Färber wrote: >> Am 18.02.2013 19:49, schrieb Peter Maydell: >>> You need to add a DeviceState* for the scu. >> >> No, not a DeviceState*, an A9SCUState. With object_initialize() and >> qdev_set_parent_

Re: [Qemu-devel] [PATCH v1 6/6] arm: a9mpcore: Coreify the SCU

2013-02-19 Thread Peter Crosthwaite
Hi Andreas, On Tue, Feb 19, 2013 at 6:19 AM, Andreas Färber wrote: > Am 18.02.2013 19:49, schrieb Peter Maydell: >> On 8 February 2013 04:03, Peter Crosthwaite >> wrote: >>> Split the SCU in a9mpcore out into its own object definition. mpcore is now >>> just a container for the mpcore components

Re: [Qemu-devel] [PATCH v1 6/6] arm: a9mpcore: Coreify the SCU

2013-02-18 Thread Andreas Färber
Am 18.02.2013 19:49, schrieb Peter Maydell: > On 8 February 2013 04:03, Peter Crosthwaite > wrote: >> Split the SCU in a9mpcore out into its own object definition. mpcore is now >> just a container for the mpcore components. > > Good idea. > >> --- a/hw/a9mpcore.c >> +++ b/hw/a9mpcore.c >> @@ -1

Re: [Qemu-devel] [PATCH v1 6/6] arm: a9mpcore: Coreify the SCU

2013-02-18 Thread Peter Maydell
On 8 February 2013 04:03, Peter Crosthwaite wrote: > Split the SCU in a9mpcore out into its own object definition. mpcore is now > just a container for the mpcore components. Good idea. > --- a/hw/a9mpcore.c > +++ b/hw/a9mpcore.c > @@ -14,107 +14,12 @@ > > typedef struct A9MPPrivState { >

[Qemu-devel] [PATCH v1 6/6] arm: a9mpcore: Coreify the SCU

2013-02-07 Thread Peter Crosthwaite
Split the SCU in a9mpcore out into its own object definition. mpcore is now just a container for the mpcore components. Signed-off-by: Peter Crosthwaite --- hw/a9mpcore.c| 119 +++-- hw/a9scu.c | 162 +++