Re: [Qemu-devel] [PATCH v1 2/3] tcg-runtime: light re-factor of lookup_tb_ptr

Hi Alex, On Wed, Jun 14, 2017 at 10:02 AM, Alex Bennée wrote: > Just a little precursor re-factoring before I was going to add a trace > point: > > - single return point, defaulting to tcg_ctx.code_gen_epilogue > - move cs_base, pc and flags inside the jump cache hit scope > - calculate the

Re: [Qemu-devel] [PATCH v1 2/3] tcg-runtime: light re-factor of lookup_tb_ptr

Richard Henderson writes: > On 06/14/2017 07:02 AM, Alex Bennée wrote: >> Just a little precursor re-factoring before I was going to add a trace >> point: >> >>- single return point, defaulting to tcg_ctx.code_gen_epilogue > > Why? Any if you're going to do that, why not init ret = epilogue

Re: [Qemu-devel] [PATCH v1 2/3] tcg-runtime: light re-factor of lookup_tb_ptr

On 06/14/2017 07:02 AM, Alex Bennée wrote: Just a little precursor re-factoring before I was going to add a trace point: - single return point, defaulting to tcg_ctx.code_gen_epilogue Why? Any if you're going to do that, why not init ret = epilogue and avoid the null test at the end?

[Qemu-devel] [PATCH v1 2/3] tcg-runtime: light re-factor of lookup_tb_ptr

Just a little precursor re-factoring before I was going to add a trace point: - single return point, defaulting to tcg_ctx.code_gen_epilogue - move cs_base, pc and flags inside the jump cache hit scope - calculate the tb_jmp_cache hash once Signed-off-by: Alex Bennée --- tcg-runtime.c | 3