Re: [Qemu-devel] [PATCH v1 1/8] hw: arm: SMMUv3 emulation model

2016-07-26 Thread Prem Mallappa
Hi Edger, > > A few first pass comments inline > Thanks for review. >> +typedef struct SMMUTransCfg { >> +union { >> +hwaddr va; /* Input to S1 */ >> +hwaddr ipa; /* Input to S2 */ >> +}; > > I think we could just use va here. > Agreed >> +u

Re: [Qemu-devel] [PATCH v1 1/8] hw: arm: SMMUv3 emulation model

2016-07-25 Thread Edgar E. Iglesias
On Thu, Jun 23, 2016 at 11:52:14AM +0530, Prem Mallappa wrote: > Big patch adds SMMUv3 model to Qemu > - As per SMMUv3 spec 16.0 > - Works with SMMUv3 driver in Linux 4.7rc1 > - Only LPAE mode translation supported > - BE mode is not supported yet > - Stage1, Stage2 and S1+S2 > - Suspen

Re: [Qemu-devel] [PATCH v1 1/8] hw: arm: SMMUv3 emulation model

2016-07-25 Thread Edgar E. Iglesias
On Thu, Jun 23, 2016 at 11:52:14AM +0530, Prem Mallappa wrote: > Big patch adds SMMUv3 model to Qemu > - As per SMMUv3 spec 16.0 > - Works with SMMUv3 driver in Linux 4.7rc1 > - Only LPAE mode translation supported > - BE mode is not supported yet > - Stage1, Stage2 and S1+S2 > - Suspen

[Qemu-devel] [PATCH v1 1/8] hw: arm: SMMUv3 emulation model

2016-06-22 Thread Prem Mallappa
Big patch adds SMMUv3 model to Qemu - As per SMMUv3 spec 16.0 - Works with SMMUv3 driver in Linux 4.7rc1 - Only LPAE mode translation supported - BE mode is not supported yet - Stage1, Stage2 and S1+S2 - Suspend/resume not tested Signed-off-by: Prem Mallappa --- hw/arm/smmu-common.c