Re: [Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI SocketAddress object

2015-09-16 Thread Paolo Bonzini
On 16/09/2015 15:52, Daniel P. Berrange wrote: > +saddr = nbd_config(s, options, &export, &local_err); You can use errp directly here. Otherwise looks fine. Paolo > +if (!saddr) { > error_propagate(errp, local_err); > return -EINVAL; > }

Re: [Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI SocketAddress object

2015-09-16 Thread Eric Blake
On 09/16/2015 07:52 AM, Daniel P. Berrange wrote: > The nbd block driver currently uses a QemuOpts object > when setting up sockets. Switch it over to use the > QAPI SocketAddress object instead. > > Signed-off-by: Daniel P. Berrange > --- > block/nbd.c | 69 > +-

[Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI SocketAddress object

2015-09-16 Thread Daniel P. Berrange
The nbd block driver currently uses a QemuOpts object when setting up sockets. Switch it over to use the QAPI SocketAddress object instead. Signed-off-by: Daniel P. Berrange --- block/nbd.c | 69 + 1 file changed, 37 insertions(+), 32 d