Re: [Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo

2018-03-02 Thread Alistair Francis
On Fri, Mar 2, 2018 at 2:35 AM, Peter Maydell wrote: > On 2 March 2018 at 10:29, Peter Maydell wrote: >> On 2 March 2018 at 04:34, Alistair Francis wrote: >>> target/arm: Report the number of cores in the cluster >>> >>> Previously we assumed that we only has a single cluster, which mean

Re: [Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 10:29, Peter Maydell wrote: > On 2 March 2018 at 04:34, Alistair Francis wrote: >> target/arm: Report the number of cores in the cluster >> >> Previously we assumed that we only has a single cluster, which meant we >> could get away with reporting smp_cpus to the gu

Re: [Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 04:34, Alistair Francis wrote: > On Thu, Mar 1, 2018 at 4:20 PM, Alistair Francis > wrote: >> The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register >> specify the number of cores present and not the number of processors. We >> have correctly been reporting th

Re: [Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo

2018-03-01 Thread Alistair Francis
On Thu, Mar 1, 2018 at 4:20 PM, Alistair Francis wrote: > The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register > specify the number of cores present and not the number of processors. We > have correctly been reporting the number of cores, so just fix the > comment to match the

[Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo

2018-03-01 Thread Alistair Francis
The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register specify the number of cores present and not the number of processors. We have correctly been reporting the number of cores, so just fix the comment to match the TRM. Signed-off-by: Alistair Francis --- target/arm/cpu64.c |