Re: [Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 14:20, Daniel P. Berrange wrote: > It is still used in VNC code for decoding of various framebuffer > encodings. Only the websock usage gets eliminated. I'm happy to > move it to util/ directory. Any preference on a name for the > APIs. I used QIOBuffer since i placed it under io/

Re: [Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 02:04:35PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:19, Daniel P. Berrange wrote: > > The Buffer code in the VNC server is useful for the IO channel > > code, so pull it out into a shared module, QIOBuffer. > > Do all traces disappear from VNC once you're done?

Re: [Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module

2015-09-22 Thread Paolo Bonzini
On 18/09/2015 15:19, Daniel P. Berrange wrote: > The Buffer code in the VNC server is useful for the IO channel > code, so pull it out into a shared module, QIOBuffer. Do all traces disappear from VNC once you're done? If not, can you instead move it to util/? Paolo > Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module

2015-09-18 Thread Daniel P. Berrange
The Buffer code in the VNC server is useful for the IO channel code, so pull it out into a shared module, QIOBuffer. Signed-off-by: Daniel P. Berrange --- include/io/buffer.h | 118 io/Makefile.objs| 3 +- io/buffer.c | 65 +