Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread Cornelia Huck
On Thu, 31 Aug 2017 17:33:13 +0200 David Hildenbrand wrote: > On 31.08.2017 17:07, Cornelia Huck wrote: > > If we know that this can't work, it makes sense to stop immediately, no? > > Hmm, like that than? > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 18ed0

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread David Hildenbrand
On 31.08.2017 17:07, Cornelia Huck wrote: > On Thu, 31 Aug 2017 17:03:21 +0200 > David Hildenbrand wrote: > >> On 31.08.2017 16:41, Cornelia Huck wrote: >>> On Wed, 30 Aug 2017 19:05:58 +0200 >>> David Hildenbrand wrote: >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread Cornelia Huck
On Thu, 31 Aug 2017 17:03:21 +0200 David Hildenbrand wrote: > On 31.08.2017 16:41, Cornelia Huck wrote: > > On Wed, 30 Aug 2017 19:05:58 +0200 > > David Hildenbrand wrote: > > > >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > >> guest tries to bring these CPUs up but f

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread David Hildenbrand
On 31.08.2017 16:41, Cornelia Huck wrote: > On Wed, 30 Aug 2017 19:05:58 +0200 > David Hildenbrand wrote: > >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x under TCG. >> >> L

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread Cornelia Huck
On Wed, 30 Aug 2017 19:05:58 +0200 David Hildenbrand wrote: > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > guest tries to bring these CPUs up but fails), because we don't support > multiple CPUs on s390x under TCG. > > Let's bail out if more than 1 are specified, so we do

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread David Hildenbrand
On 30.08.2017 21:06, Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x under TCG. >> >> Let's bail out if more

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-30 Thread Cornelia Huck
On Wed, 30 Aug 2017 21:06:55 +0200 Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: > > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > > guest tries to bring these CPUs up but fails), because we don't support > > multiple CPUs on s390x under TCG. > > > > L

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-30 Thread Thomas Huth
On 30.08.2017 19:05, David Hildenbrand wrote: > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > guest tries to bring these CPUs up but fails), because we don't support > multiple CPUs on s390x under TCG. > > Let's bail out if more than 1 are specified, so we don't raise people

[Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-30 Thread David Hildenbrand
Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the guest tries to bring these CPUs up but fails), because we don't support multiple CPUs on s390x under TCG. Let's bail out if more than 1 are specified, so we don't raise people's hope. Signed-off-by: David Hildenbrand --- hw/s390