Re: [Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent

2015-08-14 Thread Konrad Rzeszutek Wilk
> > @@ -818,10 +819,13 @@ static void xen_pt_unregister_device(PCIDevice *d) > > { > > XenPCIPassthroughState *s = XEN_PT_DEVICE(d); > > uint8_t machine_irq = s->machine_irq; > > -uint8_t intx = xen_pt_pci_intx(s); > > +uint8_t intx; > > int rc; > > > > -if (machine_ir

Re: [Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > To deal with xen_host_pci_[set|get]_ functions returning error values > and clearing ourselves in the init function we should make the > .exit (xen_pt_unregister_device) function be idempotent in case > the generic code starts calling .exit (or for

[Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent

2015-07-02 Thread Konrad Rzeszutek Wilk
To deal with xen_host_pci_[set|get]_ functions returning error values and clearing ourselves in the init function we should make the .exit (xen_pt_unregister_device) function be idempotent in case the generic code starts calling .exit (or for fun does it before calling .init!). Signed-off-by: Konr