Re: [Qemu-devel] [PATCH v1 07/41] s390x/tcg: Implement VECTOR AVERAGE

2019-04-16 Thread David Hildenbrand
On 13.04.19 00:34, Richard Henderson wrote: > On 4/11/19 12:08 AM, David Hildenbrand wrote: >> +} >> +static DisasJumpType op_vavg(DisasContext *s, DisasOps *o) >> +{ > > Watch your spacing. Whoops. > > >> +static const GVecGen3 g[4] = { >> +{ .fno = gen_helper_gvec_vavg8, }, >> +

Re: [Qemu-devel] [PATCH v1 07/41] s390x/tcg: Implement VECTOR AVERAGE

2019-04-12 Thread Richard Henderson
On 4/11/19 12:08 AM, David Hildenbrand wrote: > +} > +static DisasJumpType op_vavg(DisasContext *s, DisasOps *o) > +{ Watch your spacing. > +static const GVecGen3 g[4] = { > +{ .fno = gen_helper_gvec_vavg8, }, > +{ .fno = gen_helper_gvec_vavg16, }, > +{ .fni4 = gen_av

[Qemu-devel] [PATCH v1 07/41] s390x/tcg: Implement VECTOR AVERAGE

2019-04-11 Thread David Hildenbrand
Handle 32/64-bit elements via gvec expansion and the 8/16 bits via ool helpers. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 ++ target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.inc.c | 63 + target/s390x/vec_int_help