Re: [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions

2017-12-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20171211125705.16120-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE

Re: [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions

2017-12-11 Thread Alex Bennée
no-re...@patchew.org writes: > Hi, > > This series seems to have some coding style problems. See output below for > more information: FWIW these are either: - misidentified "spaces prohibited around that ':' (ctx:WxW)" for bitfields - existing softfloat code that has moved - two lines tha

[Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions

2017-12-11 Thread Alex Bennée
Hi, In my previous run at this I'd simply taken the existing float32 functions and attempted to copy and paste the code changing the relevant constants. Apart from the usual typos and missed bits there were sections where softfloat pulls tricks because it knows the exact bit positions of things. W