Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-08 Thread Wei Wang
On 06/09/2017 03:01 AM, Michael S. Tsirkin wrote: On Wed, Jun 07, 2017 at 09:04:29AM +0800, Wei Wang wrote: On 06/05/2017 11:38 PM, Michael S. Tsirkin wrote: On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-08 Thread Michael S. Tsirkin
On Wed, Jun 07, 2017 at 09:04:29AM +0800, Wei Wang wrote: > On 06/05/2017 11:38 PM, Michael S. Tsirkin wrote: > > On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: > > > This patch enables the virtio-net tx queue size to be configurable > > > between 256 and 1024 by the user. The queue size

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-06 Thread Wei Wang
On 06/05/2017 11:38 PM, Michael S. Tsirkin wrote: On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256 and 1024 by the user. The queue size specified by the user should be power of 2. If "tx_queue_size" is not of

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-05 Thread Wei Wang
On 06/05/2017 11:38 PM, Michael S. Tsirkin wrote: On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: /* * Calculate the number of bytes up to and including the given 'field' of @@ -57,6 +62,8 @@ static VirtIOFeature feature_sizes[] = { .end = endof(struct virtio_net_config, max

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-05 Thread Michael S. Tsirkin
On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: > @@ -1910,6 +1958,17 @@ static void virtio_net_device_realize(DeviceState > *dev, Error **errp) > return; > } > > +if (n->net_conf.tx_queue_size < VIRTIO_NET_TX_QUEUE_MIN_SIZE || > +n->net_conf.tx_queue_size > V

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-05 Thread Michael S. Tsirkin
On Mon, Jun 05, 2017 at 10:41:56AM -0500, Eric Blake wrote: > On 06/05/2017 10:38 AM, Michael S. Tsirkin wrote: > > On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: > >> This patch enables the virtio-net tx queue size to be configurable > >> between 256 and 1024 by the user. The queue size

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-05 Thread Eric Blake
On 06/05/2017 10:38 AM, Michael S. Tsirkin wrote: > On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: >> This patch enables the virtio-net tx queue size to be configurable >> between 256 and 1024 by the user. The queue size specified by the >> user should be power of 2. If "tx_queue_size" i

Re: [Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-05 Thread Michael S. Tsirkin
On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote: > This patch enables the virtio-net tx queue size to be configurable > between 256 and 1024 by the user. The queue size specified by the > user should be power of 2. If "tx_queue_size" is not offered by the > user, the default queue size, 10

[Qemu-devel] [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-05 Thread Wei Wang
This patch enables the virtio-net tx queue size to be configurable between 256 and 1024 by the user. The queue size specified by the user should be power of 2. If "tx_queue_size" is not offered by the user, the default queue size, 1024, will be used. For the traditional QEMU backend, setting the t