Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-20 Thread David Hildenbrand
On 19.09.19 18:01, Richard Henderson wrote: > On 9/19/19 2:41 AM, David Hildenbrand wrote: >>> +/* prepare the buffers - two consecutive pages */ >>> +src = valloc(ALLOC_SIZE); >>> +dst = valloc(ALLOC_SIZE); >> >> If anybody cares, I can convert the obsolete valloc into a >> posix_memal

Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread Richard Henderson
On 9/19/19 2:41 AM, David Hildenbrand wrote: >> +/* prepare the buffers - two consecutive pages */ >> +src = valloc(ALLOC_SIZE); >> +dst = valloc(ALLOC_SIZE); > > If anybody cares, I can convert the obsolete valloc into a > posix_memalign(&src, 4096, ALLOC_SIZE) etc. I don't care. It

Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread David Hildenbrand
On 19.09.19 11:28, David Hildenbrand wrote: > Let's add a test that especially verifies that no data will be touched > in case we cross page boundaries and one page access triggers a fault. > > Before the fault-safe handling fixes, the test failes with: > TESTmvc on s390x > data modi

[Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread David Hildenbrand
Let's add a test that especially verifies that no data will be touched in case we cross page boundaries and one page access triggers a fault. Before the fault-safe handling fixes, the test failes with: TESTmvc on s390x data modified during a fault make[2]: *** [../Makefile.target