Re: [Qemu-devel] [PATCH trivial 0/5] Fix error_report() calls

2011-06-23 Thread Stefan Hajnoczi
On Wed, Jun 22, 2011 at 02:03:52PM +0200, Markus Armbruster wrote: > I limited myself to truly trivial fixes. I hope that's still useful > enough to excuse a little rant. > > "bug: 0 0" is not a useful error message. Neither are "Desc next is > 128", " too short" (too short indeed), "wrong magic

Re: [Qemu-devel] [PATCH trivial 0/5] Fix error_report() calls

2011-06-22 Thread Anthony Liguori
On 06/22/2011 07:03 AM, Markus Armbruster wrote: I limited myself to truly trivial fixes. I hope that's still useful enough to excuse a little rant. "bug: 0 0" is not a useful error message. Neither are "Desc next is 128", " too short" (too short indeed), "wrong magic" (some "wrong magic" skil

[Qemu-devel] [PATCH trivial 0/5] Fix error_report() calls

2011-06-22 Thread Markus Armbruster
I limited myself to truly trivial fixes. I hope that's still useful enough to excuse a little rant. "bug: 0 0" is not a useful error message. Neither are "Desc next is 128", " too short" (too short indeed), "wrong magic" (some "wrong magic" skills will be handy to figure out what went wrong). I