Michael Tokarev writes:
> 11.06.2013 21:23, M. Mohan Kumar wrote:
>> Peter Maydell writes:
>>
>> How about this approach?
>
> Well, this is definitely wrong :)
>
>> -if test "$softmmu" = yes ; then
>> - if test "$virtfs" != no ; then
>> +
>> +if test "$virtfs" != no ; then
>> + if test "$soft
11.06.2013 23:21, Peter Maydell пишет:
> On 11 June 2013 19:19, Michael Tokarev wrote:
>> FWIW, I still don't understand what Peter Maydell dislikes
>> in a simplest case I posted initially, where we merely ignore
>> (disable) virtfs in case !softmmu.
>
> It just seems to me that rather than fixi
On 11 June 2013 19:19, Michael Tokarev wrote:
> FWIW, I still don't understand what Peter Maydell dislikes
> in a simplest case I posted initially, where we merely ignore
> (disable) virtfs in case !softmmu.
It just seems to me that rather than fixing a bug in the
makefile (it still tries to buil
11.06.2013 21:23, M. Mohan Kumar wrote:
> Peter Maydell writes:
>
> How about this approach?
Well, this is definitely wrong :)
> -if test "$softmmu" = yes ; then
> - if test "$virtfs" != no ; then
> +
> +if test "$virtfs" != no ; then
> + if test "$softmmu" = yes ; then
> if test "$cap"
Peter Maydell writes:
How about this approach?
[PATCH] configure: Disable virtfs if softmmu not enabled
Signed-off-by: M. Mohan Kumar
---
configure | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 1654413..88c2b0f 100755
--- a/configu
On 11 June 2013 13:29, Michael Tokarev wrote:
> 11.06.2013 01:45, Peter Maydell wrote:
>> This doesn't feel to me like it's quite the right way
>> to fix this bug. The current code in configure seems
>> to tangle up (a) was virtfs requested and can we do it?
>> with (b) what do we need to do if it
11.06.2013 01:45, Peter Maydell wrote:
> On 10 June 2013 21:47, Michael Tokarev wrote:
>> Or else
>>
>> ./configure --disable-system --enable-virtfs
>>
>> (which makes no sense by its own but does not error out)
>> will fail to build, because it will define CONFIG_VIRTFS,
>> and the makefile will
11.06.2013 13:22, M. Mohan Kumar wrote:
> Michael Tokarev writes:
>
>> 11.06.2013 00:47, Michael Tokarev wrote:
>>> Or else
>>>
>>> ./configure --disable-system --enable-virtfs
>>>
>>> (which makes no sense by its own but does not error out)
>>> will fail to build, because it will define CONFIG_
On 11 June 2013 10:22, M. Mohan Kumar wrote:
> I tried ./configure --disable-system --enable-virtfs and make. But didnt
> face any build failure. Could you please share your build failure
> information? virtfs-proxy-helper.1 is created inside the fsdev folder.
Michael wrote "The build fails in th
Michael Tokarev writes:
> 11.06.2013 00:47, Michael Tokarev wrote:
>> Or else
>>
>> ./configure --disable-system --enable-virtfs
>>
>> (which makes no sense by its own but does not error out)
>> will fail to build, because it will define CONFIG_VIRTFS,
>> and the makefile will try to build vir
On 10 June 2013 21:47, Michael Tokarev wrote:
> Or else
>
> ./configure --disable-system --enable-virtfs
>
> (which makes no sense by its own but does not error out)
> will fail to build, because it will define CONFIG_VIRTFS,
> and the makefile will try to build virtfs-proxy-helper
> manpage (but
11.06.2013 00:47, Michael Tokarev wrote:
> Or else
>
> ./configure --disable-system --enable-virtfs
>
> (which makes no sense by its own but does not error out)
> will fail to build, because it will define CONFIG_VIRTFS,
> and the makefile will try to build virtfs-proxy-helper
> manpage (but not
Or else
./configure --disable-system --enable-virtfs
(which makes no sense by its own but does not error out)
will fail to build, because it will define CONFIG_VIRTFS,
and the makefile will try to build virtfs-proxy-helper
manpage (but not the executable).
Cc: qemu-triv...@nongnu.org
Cc: M. Moh
13 matches
Mail list logo
