Re: [Qemu-devel] [PATCH resend] block: fix wrong order in live block migration setup

2014-06-04 Thread Chai Wen
On 06/04/2014 05:23 PM, Stefan Hajnoczi wrote: > On Wed, Jun 04, 2014 at 11:47:37AM +0800, chai wen wrote: >> >> The function init_blk_migration is better to be called before >> set_dirty_tracking as the reasons below. >> >> If we want to track dirty blocks via dirty_maps on a BlockDriverState >>

Re: [Qemu-devel] [PATCH resend] block: fix wrong order in live block migration setup

2014-06-04 Thread Stefan Hajnoczi
On Wed, Jun 04, 2014 at 11:47:37AM +0800, chai wen wrote: > > The function init_blk_migration is better to be called before > set_dirty_tracking as the reasons below. > > If we want to track dirty blocks via dirty_maps on a BlockDriverState > when doing live block-migration, its correspoding 'Blk

[Qemu-devel] [PATCH resend] block: fix wrong order in live block migration setup

2014-06-03 Thread chai wen
The function init_blk_migration is better to be called before set_dirty_tracking as the reasons below. If we want to track dirty blocks via dirty_maps on a BlockDriverState when doing live block-migration, its correspoding 'BlkMigDevState' should be added to block_mig_state.bmds_list first for su