Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-06-02 Thread Blue Swirl
On Thu, May 31, 2012 at 6:53 PM, Paul Brook wrote: >> >> +void cpu_tlb_flush(CPUState *cpu, bool flush_global) >> >> +{ >> >> +    CPUClass *cc = CPU_GET_CLASS(cpu); >> >> + >> >> +    g_assert(cc->tlb_flush != NULL); >> >> + >> >> +    cc->tlb_flush(cpu, flush_global); >> >> +} >> > >> > This nee

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-31 Thread Paul Brook
> >> +void cpu_tlb_flush(CPUState *cpu, bool flush_global) > >> +{ > >> +CPUClass *cc = CPU_GET_CLASS(cpu); > >> + > >> +g_assert(cc->tlb_flush != NULL); > >> + > >> +cc->tlb_flush(cpu, flush_global); > >> +} > > > > This needs to be able to call tlb_flush() itself > > rather than havi

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-30 Thread Andreas Färber
Am 30.05.2012 09:53, schrieb Alexander Graf: > Mind to elaborate (in the patch description maybe) why we need a CPU specific > TLB flush callback that merely calls the globally visible tlb_flush? :) Ouch! That's one patch description I forgot to fill in. :-/ The issue is that env is defined in X

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-30 Thread Andreas Färber
Am 30.05.2012 11:28, schrieb Peter Maydell: > On 23 May 2012 04:08, Andreas Färber wrote: >> +void cpu_tlb_flush(CPUState *cpu, bool flush_global) >> +{ >> +CPUClass *cc = CPU_GET_CLASS(cpu); >> + >> +g_assert(cc->tlb_flush != NULL); >> + >> +cc->tlb_flush(cpu, flush_global); >> +} >

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-30 Thread Peter Maydell
On 23 May 2012 04:08, Andreas Färber wrote: > +void cpu_tlb_flush(CPUState *cpu, bool flush_global) > +{ > +    CPUClass *cc = CPU_GET_CLASS(cpu); > + > +    g_assert(cc->tlb_flush != NULL); > + > +    cc->tlb_flush(cpu, flush_global); > +} This needs to be able to call tlb_flush() itself rather

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-30 Thread Alexander Graf
Mind to elaborate (in the patch description maybe) why we need a CPU specific TLB flush callback that merely calls the globally visible tlb_flush? :) Alex On 23.05.2012, at 05:08, Andreas Färber wrote: > Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-30 Thread Alexander Graf
On 30.05.2012, at 10:48, 陳韋任 (Wei-Ren Chen) wrote: > On Wed, May 30, 2012 at 09:53:20AM +0200, Alexander Graf wrote: >> Mind to elaborate (in the patch description maybe) why we need a CPU >> specific TLB flush callback that merely calls the globally visible >> tlb_flush? :) > > For future ex

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-30 Thread Wei-Ren Chen
On Wed, May 30, 2012 at 09:53:20AM +0200, Alexander Graf wrote: > Mind to elaborate (in the patch description maybe) why we need a CPU specific > TLB flush callback that merely calls the globally visible tlb_flush? :) For future extension? ;) Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Sy

[Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-22 Thread Andreas Färber
Signed-off-by: Andreas Färber --- include/qemu/cpu.h | 12 qom/cpu.c |9 + target-alpha/cpu.c | 16 target-arm/cpu.c| 10 ++ target-cris/cpu.c | 10 ++ target-i386/cpu.c