Re: [Qemu-devel] [PATCH qom-cpu for-2.0] cpu: Avoid QOM casts for CPU()

2014-03-31 Thread Andreas Färber
Am 28.03.2014 18:10, schrieb Andreas Färber: > Am 28.03.2014 16:52, schrieb Peter Maydell: >> On 28 March 2014 15:49, Andreas Färber wrote: >>> diff --git a/include/qom/cpu.h b/include/qom/cpu.h >>> index f99885a..0aa1bdc 100644 >>> --- a/include/qom/cpu.h >>> +++ b/include/qom/cpu.h >>> @@ -53,7

Re: [Qemu-devel] [PATCH qom-cpu for-2.0] cpu: Avoid QOM casts for CPU()

2014-03-28 Thread Peter Maydell
On 28 March 2014 15:49, Andreas Färber wrote: > CPU address spaces touching load and store helpers as well as the > movement of (almost) all fields from CPU_COMMON to CPUState have led to > a noticeable increase of CPU() usage in "hot" paths for both TCG and KVM. > > While CPU()'s OBJECT_CHECK() m

Re: [Qemu-devel] [PATCH qom-cpu for-2.0] cpu: Avoid QOM casts for CPU()

2014-03-28 Thread Andreas Färber
Am 28.03.2014 16:52, schrieb Peter Maydell: > On 28 March 2014 15:49, Andreas Färber wrote: >> CPU address spaces touching load and store helpers as well as the >> movement of (almost) all fields from CPU_COMMON to CPUState have led to >> a noticeable increase of CPU() usage in "hot" paths for bot

[Qemu-devel] [PATCH qom-cpu for-2.0] cpu: Avoid QOM casts for CPU()

2014-03-28 Thread Andreas Färber
CPU address spaces touching load and store helpers as well as the movement of (almost) all fields from CPU_COMMON to CPUState have led to a noticeable increase of CPU() usage in "hot" paths for both TCG and KVM. While CPU()'s OBJECT_CHECK() might help detect development errors, i.e. in form of cra