Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-22 Thread Jason Wang
On 2016年09月19日 19:59, Paolo Bonzini wrote: On 19/09/2016 02:33, Alexey Kardashevskiy wrote: On 15/09/16 07:04, Paolo Bonzini wrote: On 13/09/2016 09:11, Alexey Kardashevskiy wrote: The tap backend is already using qemu-bridge-helper to attach tap interface to a bridge but (unlike the bridg

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-22 Thread Jason Wang
On 2016年09月14日 23:12, Eric Blake wrote: On 09/14/2016 09:17 AM, Greg Kurz wrote: On Tue, 13 Sep 2016 17:11:54 +1000 Alexey Kardashevskiy wrote: The tap backend is already using qemu-bridge-helper to attach tap interface to a bridge but (unlike the bridge backend) it always uses the default

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-19 Thread Paolo Bonzini
On 19/09/2016 02:33, Alexey Kardashevskiy wrote: > On 15/09/16 07:04, Paolo Bonzini wrote: >> >> >> On 13/09/2016 09:11, Alexey Kardashevskiy wrote: >>> The tap backend is already using qemu-bridge-helper to attach tap >>> interface to a bridge but (unlike the bridge backend) it always uses >>> t

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-18 Thread Alexey Kardashevskiy
On 15/09/16 07:04, Paolo Bonzini wrote: > > > On 13/09/2016 09:11, Alexey Kardashevskiy wrote: >> The tap backend is already using qemu-bridge-helper to attach tap >> interface to a bridge but (unlike the bridge backend) it always uses >> the default bridge name - br0. >> >> This adds a "br" prop

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-14 Thread Paolo Bonzini
On 13/09/2016 09:11, Alexey Kardashevskiy wrote: > The tap backend is already using qemu-bridge-helper to attach tap > interface to a bridge but (unlike the bridge backend) it always uses > the default bridge name - br0. > > This adds a "br" property support to the tap backend. > > Signed-off-b

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-14 Thread Eric Blake
On 09/14/2016 09:17 AM, Greg Kurz wrote: > On Tue, 13 Sep 2016 17:11:54 +1000 > Alexey Kardashevskiy wrote: > >> The tap backend is already using qemu-bridge-helper to attach tap >> interface to a bridge but (unlike the bridge backend) it always uses >> the default bridge name - br0. >> >> This a

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-14 Thread Eric Blake
On 09/13/2016 11:23 PM, Alexey Kardashevskiy wrote: >>> >>> Also, we don't have to abbreviate; 'bridge-name' may be easier to >>> understand than 'br', as well as a mention of the default value if the >>> parameter is not supplied. > > > The existing NetdevBridgeOptions does not do this in json

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-14 Thread Greg Kurz
On Tue, 13 Sep 2016 17:11:54 +1000 Alexey Kardashevskiy wrote: > The tap backend is already using qemu-bridge-helper to attach tap > interface to a bridge but (unlike the bridge backend) it always uses > the default bridge name - br0. > > This adds a "br" property support to the tap backend. >

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-13 Thread Alexey Kardashevskiy
On 14/09/16 01:39, Greg Kurz wrote: > On Tue, 13 Sep 2016 09:49:09 -0500 > Eric Blake wrote: > >> On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote: >>> The tap backend is already using qemu-bridge-helper to attach tap >>> interface to a bridge but (unlike the bridge backend) it always uses >>>

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-13 Thread Greg Kurz
On Tue, 13 Sep 2016 09:49:09 -0500 Eric Blake wrote: > On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote: > > The tap backend is already using qemu-bridge-helper to attach tap > > interface to a bridge but (unlike the bridge backend) it always uses > > the default bridge name - br0. > > > > Thi

Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-13 Thread Eric Blake
On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote: > The tap backend is already using qemu-bridge-helper to attach tap > interface to a bridge but (unlike the bridge backend) it always uses > the default bridge name - br0. > > This adds a "br" property support to the tap backend. > > Signed-off-

[Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

2016-09-13 Thread Alexey Kardashevskiy
The tap backend is already using qemu-bridge-helper to attach tap interface to a bridge but (unlike the bridge backend) it always uses the default bridge name - br0. This adds a "br" property support to the tap backend. Signed-off-by: Alexey Kardashevskiy -- Changes: v2: * documented a new membe