Re: [Qemu-devel] [PATCH qemu 6/6] virtio-input: evdev passthrough

2014-04-11 Thread Gerd Hoffmann
Hi, > > I guess the only thing we might want to here is bail out in case the > > major version is != 1 (which implies a incompatible change). The major > > version didn't change so far though, and I think it is highly unlikely > > that it'll ever happen. > > > > cheers, > > Gerd > > BTW thi

Re: [Qemu-devel] [PATCH qemu 6/6] virtio-input: evdev passthrough

2014-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2014 at 01:57:03PM +0200, Gerd Hoffmann wrote: > Hi, > > > > +static void virtio_input_host_event(void *opaque) > > > +{ > > > +VirtIOInputHost *vhost = opaque; > > > > I'd prefer a name that does not imply > > vhost infrastructure > > ok. > > > > +rc = ioctl(vhost->fd

Re: [Qemu-devel] [PATCH qemu 6/6] virtio-input: evdev passthrough

2014-04-10 Thread Gerd Hoffmann
Hi, > > +static void virtio_input_host_event(void *opaque) > > +{ > > +VirtIOInputHost *vhost = opaque; > > I'd prefer a name that does not imply > vhost infrastructure ok. > > +rc = ioctl(vhost->fd, EVIOCGVERSION, &ver); > > +if (rc < 0) { > > +error_setg(errp, "%s: is no

Re: [Qemu-devel] [PATCH qemu 6/6] virtio-input: evdev passthrough

2014-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2014 at 11:07:54AM +0200, Gerd Hoffmann wrote: > This allows to assign host input devices to the guest: > > qemu -device virto-input-host-pci,evdev=/dev/input/event > > The guest gets exclusive access to the input device, so be careful > with assigning the keyboard if you have onl

[Qemu-devel] [PATCH qemu 6/6] virtio-input: evdev passthrough

2014-04-10 Thread Gerd Hoffmann
This allows to assign host input devices to the guest: qemu -device virto-input-host-pci,evdev=/dev/input/event The guest gets exclusive access to the input device, so be careful with assigning the keyboard if you have only one connected to your machine. Signed-off-by: Gerd Hoffmann --- hw/inp