Re: [Qemu-devel] [PATCH qemu] spapr_pci: Fix endianness in assigned-addresses property

2019-01-31 Thread David Gibson
On Fri, Feb 01, 2019 at 11:56:22AM +1100, Alexey Kardashevskiy wrote: > reg->phys_hi and assigned->phys_hi are big endian but we do an extra > byteswap anyway when copying reg->phys_hi to assigned->phys_hi. > To make things slightly more messy, we also add a relocatable bit (b_n()) > although in th

[Qemu-devel] [PATCH qemu] spapr_pci: Fix endianness in assigned-addresses property

2019-01-31 Thread Alexey Kardashevskiy
reg->phys_hi and assigned->phys_hi are big endian but we do an extra byteswap anyway when copying reg->phys_hi to assigned->phys_hi. To make things slightly more messy, we also add a relocatable bit (b_n()) although in the right endianness. This fixes endianness of assigned->phys_hi. This is unli