Re: [Qemu-devel] [PATCH for 3.0 3/4] tests: use error_abort in places expecting errors

2018-07-18 Thread Philippe Mathieu-Daudé
On 07/18/2018 06:38 AM, Daniel P. Berrangé wrote: > Most of the TLS related tests are passing an in a "Error" object to > methods that are expected to fail, but then ignoring any error that is > set and instead asserting on a return value. This means that when an > error is unexpectedly raised, no

[Qemu-devel] [PATCH for 3.0 3/4] tests: use error_abort in places expecting errors

2018-07-18 Thread Daniel P . Berrangé
Most of the TLS related tests are passing an in a "Error" object to methods that are expected to fail, but then ignoring any error that is set and instead asserting on a return value. This means that when an error is unexpectedly raised, no information about it is printed out, making failures hard