Re: [Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-27 Thread Stefan Hajnoczi
On Mon, Nov 27, 2017 at 11:26:34AM +0800, Jason Wang wrote: > > > On 2017年11月24日 18:44, Stefan Hajnoczi wrote: > > On Fri, Nov 24, 2017 at 10:57:11AM +0800, Jason Wang wrote: > > > On 2017年11月23日 18:59, Stefan Hajnoczi wrote: > > > > On Thu, Nov 23, 2017 at 11:37:46AM +0800, Jason Wang wrote: > >

Re: [Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-26 Thread Jason Wang
On 2017年11月24日 18:44, Stefan Hajnoczi wrote: On Fri, Nov 24, 2017 at 10:57:11AM +0800, Jason Wang wrote: On 2017年11月23日 18:59, Stefan Hajnoczi wrote: On Thu, Nov 23, 2017 at 11:37:46AM +0800, Jason Wang wrote: Guest state should not be touched if VM is stopped, unfortunately we didn't check

Re: [Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-24 Thread Stefan Hajnoczi
On Fri, Nov 24, 2017 at 10:57:11AM +0800, Jason Wang wrote: > On 2017年11月23日 18:59, Stefan Hajnoczi wrote: > > On Thu, Nov 23, 2017 at 11:37:46AM +0800, Jason Wang wrote: > > > Guest state should not be touched if VM is stopped, unfortunately we > > > didn't check running state and tried to drain t

Re: [Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-23 Thread Jason Wang
On 2017年11月23日 18:59, Stefan Hajnoczi wrote: On Thu, Nov 23, 2017 at 11:37:46AM +0800, Jason Wang wrote: Guest state should not be touched if VM is stopped, unfortunately we didn't check running state and tried to drain tx queue unconditionally in virtio_net_set_status(). A crash was then noti

Re: [Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-23 Thread Stefan Hajnoczi
On Thu, Nov 23, 2017 at 11:37:46AM +0800, Jason Wang wrote: > Guest state should not be touched if VM is stopped, unfortunately we > didn't check running state and tried to drain tx queue unconditionally > in virtio_net_set_status(). A crash was then noticed as a migration > destination when user t

[Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-22 Thread Jason Wang
Guest state should not be touched if VM is stopped, unfortunately we didn't check running state and tried to drain tx queue unconditionally in virtio_net_set_status(). A crash was then noticed as a migration destination when user type quit after virtqueue state is loaded but before region cache is