Re: [Qemu-devel] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste

2017-07-24 Thread Laurent Vivier
Le 24/07/2017 à 21:19, Philippe Mathieu-Daudé a écrit : > On 07/24/2017 04:01 PM, Richard Henderson wrote: >> On 07/24/2017 11:54 AM, Laurent Vivier wrote: >>> Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ada2

Re: [Qemu-devel] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste

2017-07-24 Thread Philippe Mathieu-Daudé
On 07/24/2017 04:01 PM, Richard Henderson wrote: On 07/24/2017 11:54 AM, Laurent Vivier wrote: Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ada2a91b64..1a2f421aab 100644 --- a/target/m68k/translate.c +++ b/target/m6

Re: [Qemu-devel] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste

2017-07-24 Thread Richard Henderson
On 07/24/2017 11:54 AM, Laurent Vivier wrote: Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ada2a91b64..1a2f421aab 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1321,7 +1321,8 @@ static void g

Re: [Qemu-devel] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste

2017-07-24 Thread Laurent Vivier
Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : > db3d7945ae extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, 5] > > target/m68k/translate.c:1323:70: warning: identical expressions on both sides > of logical operator > if (op == CC_OP_ADDB || op == CC_OP_ADDW || op

[Qemu-devel] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste

2017-07-24 Thread Philippe Mathieu-Daudé
db3d7945ae extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, 5] target/m68k/translate.c:1323:70: warning: identical expressions on both sides of logical operator if (op == CC_OP_ADDB || op == CC_OP_ADDW || op == CC_OP_ADDL || op == CC_OP_ADDB || op == CC_OP_ADDW