Stefan Weil writes:
> Hi Jeff,
>
> the scenario which you describe here is not one which I'd call
> "realistic". Why should a user create a VHD image with VPC
[...]
Maybe, but why run a risk for 1.4? Let's delay your fix to 1.5. Gives
us plenty of time to hash out the issues.
Am 12.02.2013 16:18, schrieb Jeff Cody:
> On Tue, Feb 12, 2013 at 03:47:38PM +0100, Stefan Weil wrote:
>> Am 11.02.2013 22:20, schrieb Jeff Cody:
>>> On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote:
Paolo Bonzini writes:
> Il 11/02/2013 21:13, Anthony Liguori ha scrit
Kevin Wolf writes:
> Am 11.02.2013 22:14, schrieb Anthony Liguori:
>> Paolo Bonzini writes:
>>
>>> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
Applied. Thanks.
Regards,
Anthony Liguori
>>>
>>> I guess this was a mistake, please revert.
>>
>> No, it wasn't. The p
On Tue, Feb 12, 2013 at 03:47:38PM +0100, Stefan Weil wrote:
> Am 11.02.2013 22:20, schrieb Jeff Cody:
> > On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote:
> >> Paolo Bonzini writes:
> >>
> >>> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
> Applied. Thanks.
>
>
Am 12.02.2013 12:24, schrieb Stefan Hajnoczi:
> On Tue, Feb 12, 2013 at 10:12:59AM +0100, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> Il 12/02/2013 09:42, Kevin Wolf ha scritto:
>> No, it wasn't. The patch was reviewed and tested. What's the problem.
>> It's proposed for 1.4
Am 11.02.2013 22:20, schrieb Jeff Cody:
> On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote:
>> Paolo Bonzini writes:
>>
>>> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
Applied. Thanks.
Regards,
Anthony Liguori
>>> I guess this was a mistake, please rev
Am 12.02.2013 09:42, schrieb Kevin Wolf:
> It makes qemu use the wrong size for VHD images created by Virtual PC
> that used to work with qemu. This is a regression that can result in
> images appearing corrupted in Virtual PC, and we need very good
> justification to apply such a patch.
>
> At the
On Tue, Feb 12, 2013 at 10:12:59AM +0100, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
> > Il 12/02/2013 09:42, Kevin Wolf ha scritto:
> >>> > No, it wasn't. The patch was reviewed and tested. What's the problem.
> >>> > It's proposed for 1.4 so it's now or never.
> >> The problem is that
Paolo Bonzini writes:
> Il 12/02/2013 09:42, Kevin Wolf ha scritto:
>>> > No, it wasn't. The patch was reviewed and tested. What's the problem.
>>> > It's proposed for 1.4 so it's now or never.
>> The problem is that the test failed. Why do we even test things if we
>> commit anyway when the te
Am 11.02.2013 22:33, schrieb Stefan Weil:
> Does the patch really break Virtual PC VHD compatibility?
>
> Or does VPC simply pass the size calculated from CHSto the
> guest - no matter how the disk image was created?In this case
> I see no need that QEMU must show the same behaviour.
> It's import
Il 12/02/2013 09:42, Kevin Wolf ha scritto:
>> > No, it wasn't. The patch was reviewed and tested. What's the problem.
>> > It's proposed for 1.4 so it's now or never.
> The problem is that the test failed. Why do we even test things if we
> commit anyway when the test fails?
>
> And why do we h
Am 11.02.2013 22:14, schrieb Anthony Liguori:
> Paolo Bonzini writes:
>
>> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>
>> I guess this was a mistake, please revert.
>
> No, it wasn't. The patch was reviewed and tested. What
On Mon, Feb 11, 2013 at 10:33:53PM +0100, Stefan Weil wrote:
> Am 11.02.2013 20:38, schrieb Jeff Cody:
> > I've done some testing back and forth between VPC, Win Server 2012
> > Hyper-V, and qemu/kvm with and without this patch applied.
> >
> > The short: this patch will break Virtual PC VHD compat
Am 11.02.2013 20:38, schrieb Jeff Cody:
> I've done some testing back and forth between VPC, Win Server 2012
> Hyper-V, and qemu/kvm with and without this patch applied.
>
> The short: this patch will break Virtual PC VHD compatibility (as it
> exists under Win7), but allow compatibility for VHD fi
On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote:
> Paolo Bonzini writes:
>
> > Il 11/02/2013 21:13, Anthony Liguori ha scritto:
> >> Applied. Thanks.
> >>
> >> Regards,
> >>
> >> Anthony Liguori
> >
> > I guess this was a mistake, please revert.
>
> No, it wasn't. The patch w
Paolo Bonzini writes:
> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
>> Applied. Thanks.
>>
>> Regards,
>>
>> Anthony Liguori
>
> I guess this was a mistake, please revert.
No, it wasn't. The patch was reviewed and tested. What's the problem.
It's proposed for 1.4 so it's now or never.
Il 11/02/2013 21:13, Anthony Liguori ha scritto:
> Applied. Thanks.
>
> Regards,
>
> Anthony Liguori
I guess this was a mistake, please revert.
Paolo
On Mon, Feb 11, 2013 at 09:09:48PM +0100, Kevin Wolf wrote:
> Am 11.02.2013 20:38, schrieb Jeff Cody:
> > I've done some testing back and forth between VPC, Win Server 2012
> > Hyper-V, and qemu/kvm with and without this patch applied.
>
> First of all, thanks a lot for doing all the testing!
>
>
Applied. Thanks.
Regards,
Anthony Liguori
Am 11.02.2013 20:38, schrieb Jeff Cody:
> I've done some testing back and forth between VPC, Win Server 2012
> Hyper-V, and qemu/kvm with and without this patch applied.
First of all, thanks a lot for doing all the testing!
> The short: this patch will break Virtual PC VHD compatibility (as it
>
On Mon, Feb 11, 2013 at 09:54:56AM +0100, Kevin Wolf wrote:
> Am 08.02.2013 18:43, schrieb Stefan Weil:
> > Am 08.02.2013 13:14, schrieb Jeff Cody:
> >> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote:
> >>> Am 07.02.2013 20:26, schrieb Stefan Weil:
> From: Stefan Weil
>
> >>>
Am 08.02.2013 18:43, schrieb Stefan Weil:
> Am 08.02.2013 13:14, schrieb Jeff Cody:
>> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote:
>>> Am 07.02.2013 20:26, schrieb Stefan Weil:
From: Stefan Weil
The size calculated from the CHS values is not the real image (disk) siz
On Fri, Feb 08, 2013 at 07:14:33AM -0500, Jeff Cody wrote:
> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote:
> > Am 07.02.2013 20:26, schrieb Stefan Weil:
> > > From: Stefan Weil
> > >
> > > The size calculated from the CHS values is not the real image (disk) size,
> > > but usually a
Am 08.02.2013 13:14, schrieb Jeff Cody:
> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote:
>> Am 07.02.2013 20:26, schrieb Stefan Weil:
>>> From: Stefan Weil
>>>
>>> The size calculated from the CHS values is not the real image (disk) size,
>>> but usually a smaller value. This is cause
Am 08.02.2013 09:18, schrieb Stefan Hajnoczi:
> On Thu, Feb 07, 2013 at 08:26:52PM +0100, Stefan Weil wrote:
>> From: Stefan Weil
> Should be "From: Stefan Weil "?
Yes, of course.
Maybe whoever applies the patch can fix this, please.
Thanks,
Stefan W.
On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote:
> Am 07.02.2013 20:26, schrieb Stefan Weil:
> > From: Stefan Weil
> >
> > The size calculated from the CHS values is not the real image (disk) size,
> > but usually a smaller value. This is caused by rounding effects.
> >
> > Only older
Am 07.02.2013 20:26, schrieb Stefan Weil:
> From: Stefan Weil
>
> The size calculated from the CHS values is not the real image (disk) size,
> but usually a smaller value. This is caused by rounding effects.
>
> Only older operating systems use CHS. Such guests won't be able to use
> the whole d
On Thu, Feb 07, 2013 at 08:26:52PM +0100, Stefan Weil wrote:
> From: Stefan Weil
Should be "From: Stefan Weil "?
> The size calculated from the CHS values is not the real image (disk) size,
> but usually a smaller value. This is caused by rounding effects.
>
> Only older operating systems use C
From: Stefan Weil
The size calculated from the CHS values is not the real image (disk) size,
but usually a smaller value. This is caused by rounding effects.
Only older operating systems use CHS. Such guests won't be able to use
the whole disk. All modern operating systems use the real size.
Th
29 matches
Mail list logo
