Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-05 Thread Greg Kurz
On Fri, 5 Jul 2019 14:56:23 +1000 David Gibson wrote: > On Thu, Jul 04, 2019 at 10:12:04AM +0200, Greg Kurz wrote: > > On Thu, 4 Jul 2019 10:23:57 +1000 > > David Gibson wrote: > > > > > On Wed, Jul 03, 2019 at 07:50:12PM +0200, Greg Kurz wrote: > > > > ics_set_kvm_state_one() is called either

Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-04 Thread David Gibson
On Thu, Jul 04, 2019 at 10:12:04AM +0200, Greg Kurz wrote: > On Thu, 4 Jul 2019 10:23:57 +1000 > David Gibson wrote: > > > On Wed, Jul 03, 2019 at 07:50:12PM +0200, Greg Kurz wrote: > > > ics_set_kvm_state_one() is called either during reset, in which case > > > both 'saved priority' and 'current

Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-04 Thread Greg Kurz
On Thu, 4 Jul 2019 10:23:57 +1000 David Gibson wrote: > On Wed, Jul 03, 2019 at 07:50:12PM +0200, Greg Kurz wrote: > > ics_set_kvm_state_one() is called either during reset, in which case > > both 'saved priority' and 'current priority' are equal to 0xff, or > > during migration. In the latter ca

Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-03 Thread David Gibson
On Wed, Jul 03, 2019 at 07:50:12PM +0200, Greg Kurz wrote: > ics_set_kvm_state_one() is called either during reset, in which case > both 'saved priority' and 'current priority' are equal to 0xff, or > during migration. In the latter case, 'saved priority' may differ > from 'current priority' only i

Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/156217621200.562209.8968691631915806468.st...@bahia.lan/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-03 Thread Greg Kurz
ics_set_kvm_state_one() is called either during reset, in which case both 'saved priority' and 'current priority' are equal to 0xff, or during migration. In the latter case, 'saved priority' may differ from 'current priority' only if the interrupt had been masked with the ibm,int-off RTAS call. Ins