Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Kevin Wolf
Am 23.07.2019 um 12:21 hat Max Reitz geschrieben: > On 23.07.19 12:02, Kevin Wolf wrote: > > Am 23.07.2019 um 11:41 hat Max Reitz geschrieben: > >> On 23.07.19 10:52, Kevin Wolf wrote: > >>> Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: > bdrv_set_aio_context_ignore() can only work in the

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Max Reitz
On 23.07.19 12:02, Kevin Wolf wrote: > Am 23.07.2019 um 11:41 hat Max Reitz geschrieben: >> On 23.07.19 10:52, Kevin Wolf wrote: >>> Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: bdrv_set_aio_context_ignore() can only work in the main loop: bdrv_drained_begin() only works in the main

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Kevin Wolf
Am 23.07.2019 um 11:41 hat Max Reitz geschrieben: > On 23.07.19 10:52, Kevin Wolf wrote: > > Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: > >> bdrv_set_aio_context_ignore() can only work in the main loop: > >> bdrv_drained_begin() only works in the main loop and the node's (old) > >> AioContex

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Max Reitz
On 23.07.19 10:52, Kevin Wolf wrote: > Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: >> bdrv_set_aio_context_ignore() can only work in the main loop: >> bdrv_drained_begin() only works in the main loop and the node's (old) >> AioContext; and bdrv_drained_end() really only works in the main loop

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Kevin Wolf
Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: > bdrv_set_aio_context_ignore() can only work in the main loop: > bdrv_drained_begin() only works in the main loop and the node's (old) > AioContext; and bdrv_drained_end() really only works in the main loop > and the node's (new) AioContext (contra

[Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-22 Thread Max Reitz
bdrv_set_aio_context_ignore() can only work in the main loop: bdrv_drained_begin() only works in the main loop and the node's (old) AioContext; and bdrv_drained_end() really only works in the main loop and the node's (new) AioContext (contrary to its current comment, which is just wrong). Conseque