On 11/19/18 4:59 PM, Samuel Thibault wrote:
Mmm, I don't think any portability issue remains. SO_OOBINLINE is used
in other places, the rest is portable. There is the setsid() call which
may just not make sense on Windows, but we could just disable it there.
I have pushed to
https://people.debi
Hello,
Daniel P. Berrangé, le mer. 14 nov. 2018 14:22:34 +, a ecrit:
> On Wed, Nov 14, 2018 at 04:36:05PM +0400, Marc-André Lureau wrote:
> > Use g_spawn_async_with_fds() to setup the child.
> >
> > GSpawn handles reaping the child, and closing parent file descriptors.
>
> The g_spawn* famil
Marc-André Lureau, le mer. 14 nov. 2018 16:36:05 +0400, a ecrit:
> Use g_spawn_async_with_fds() to setup the child.
>
> GSpawn handles reaping the child, and closing parent file descriptors.
>
> Signed-off-by: Marc-André Lureau
Applied to my slirp-2 tree, thanks!
Samuel
On Wed, Nov 14, 2018 at 04:36:05PM +0400, Marc-André Lureau wrote:
> Use g_spawn_async_with_fds() to setup the child.
>
> GSpawn handles reaping the child, and closing parent file descriptors.
The g_spawn* family of APIs is portable to Win32, which the current
fork/exec code in slirp is not.
So
Use g_spawn_async_with_fds() to setup the child.
GSpawn handles reaping the child, and closing parent file descriptors.
Signed-off-by: Marc-André Lureau
---
slirp/misc.c | 75 +---
1 file changed, 36 insertions(+), 39 deletions(-)
diff --git a/sl
