Re: [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash

2018-11-27 Thread Cong Li
- Original Message - > From: "Markus Armbruster" > To: qemu-devel@nongnu.org > Cc: c...@redhat.com, f...@euphon.net, stefa...@redhat.com, pbonz...@redhat.com > Sent: Tuesday, November 27, 2018 4:41:43 PM > Subject: [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash > > qemu_vf

Re: [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash

2018-11-27 Thread Peter Maydell
On Tue, 27 Nov 2018 at 08:42, Markus Armbruster wrote: > > qemu_vfio_open_common() initializes s->lock only after passing s to > qemu_vfio_dma_map() via qemu_vfio_init_ramblock(). > qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes. > > Fix by initializing s->lock first. > > RHB

Re: [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash

2018-11-27 Thread Stefan Hajnoczi
On Tue, Nov 27, 2018 at 09:41:43AM +0100, Markus Armbruster wrote: > qemu_vfio_open_common() initializes s->lock only after passing s to > qemu_vfio_dma_map() via qemu_vfio_init_ramblock(). > qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes. > > Fix by initializing s->lock firs

Re: [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash

2018-11-27 Thread Cornelia Huck
On Tue, 27 Nov 2018 09:41:43 +0100 Markus Armbruster wrote: > qemu_vfio_open_common() initializes s->lock only after passing s to > qemu_vfio_dma_map() via qemu_vfio_init_ramblock(). > qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes. > > Fix by initializing s->lock first. >

[Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash

2018-11-27 Thread Markus Armbruster
qemu_vfio_open_common() initializes s->lock only after passing s to qemu_vfio_dma_map() via qemu_vfio_init_ramblock(). qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes. Fix by initializing s->lock first. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1645840 Fixes: 418026ca