Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2018-02-07 Thread Fam Zheng
On Wed, Feb 7, 2018 at 9:10 PM, Kevin Wolf wrote: > Am 07.02.2018 um 13:39 hat Fam Zheng geschrieben: >> On Wed, Feb 7, 2018 at 6:51 PM, Kevin Wolf wrote: >> > Am 07.02.2018 um 02:48 hat Fam Zheng geschrieben: >> >> On Tue, Feb 6, 2018 at 11:32 PM, Kevin Wolf wrote: >> >> > I got a bug assigned

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2018-02-07 Thread Kevin Wolf
Am 07.02.2018 um 13:39 hat Fam Zheng geschrieben: > On Wed, Feb 7, 2018 at 6:51 PM, Kevin Wolf wrote: > > Am 07.02.2018 um 02:48 hat Fam Zheng geschrieben: > >> On Tue, Feb 6, 2018 at 11:32 PM, Kevin Wolf wrote: > >> > I got a bug assigned where we have a large (200 GB) fragmented qcow2 > >> > im

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2018-02-07 Thread Fam Zheng
On Wed, Feb 7, 2018 at 6:51 PM, Kevin Wolf wrote: > Am 07.02.2018 um 02:48 hat Fam Zheng geschrieben: >> On Tue, Feb 6, 2018 at 11:32 PM, Kevin Wolf wrote: >> > Am 18.04.2017 um 16:30 hat Fam Zheng geschrieben: >> >> During block job completion, nothing is preventing >> >> block_job_defer_to_main

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2018-02-07 Thread Kevin Wolf
Am 07.02.2018 um 02:48 hat Fam Zheng geschrieben: > On Tue, Feb 6, 2018 at 11:32 PM, Kevin Wolf wrote: > > Am 18.04.2017 um 16:30 hat Fam Zheng geschrieben: > >> During block job completion, nothing is preventing > >> block_job_defer_to_main_loop_bh from being called in a nested > >> aio_poll(), w

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2018-02-06 Thread Fam Zheng
On Tue, Feb 6, 2018 at 11:32 PM, Kevin Wolf wrote: > Am 18.04.2017 um 16:30 hat Fam Zheng geschrieben: >> During block job completion, nothing is preventing >> block_job_defer_to_main_loop_bh from being called in a nested >> aio_poll(), which is a trouble, such as in this code path: >> >> qmp_

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2018-02-06 Thread Kevin Wolf
Am 18.04.2017 um 16:30 hat Fam Zheng geschrieben: > During block job completion, nothing is preventing > block_job_defer_to_main_loop_bh from being called in a nested > aio_poll(), which is a trouble, such as in this code path: > > qmp_block_commit > commit_active_start > bdrv_re

[Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2017-04-18 Thread Fam Zheng
During block job completion, nothing is preventing block_job_defer_to_main_loop_bh from being called in a nested aio_poll(), which is a trouble, such as in this code path: qmp_block_commit commit_active_start bdrv_reopen bdrv_reopen_multiple bdrv_reopen_prep