Re: [Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Max Reitz
On 07.04.2017 15:53, Eric Blake wrote: > On 04/07/2017 05:32 AM, Kevin Wolf wrote: >> The assertion is currently failing. We can't require callers to have >> write permissions when all they are doing is a read, so comment it out. >> Add a FIXME comment in the code so that the check is re-enabled wh

Re: [Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Eric Blake
On 04/07/2017 05:32 AM, Kevin Wolf wrote: > The assertion is currently failing. We can't require callers to have > write permissions when all they are doing is a read, so comment it out. > Add a FIXME comment in the code so that the check is re-enabled when > copy on read is refactored into its own

Re: [Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Richard W.M. Jones
On Fri, Apr 07, 2017 at 12:32:45PM +0200, Kevin Wolf wrote: > The assertion is currently failing. We can't require callers to have > write permissions when all they are doing is a read, so comment it out. > Add a FIXME comment in the code so that the check is re-enabled when > copy on read is refac

[Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Kevin Wolf
The assertion is currently failing. We can't require callers to have write permissions when all they are doing is a read, so comment it out. Add a FIXME comment in the code so that the check is re-enabled when copy on read is refactored into its own filter driver. Reported-by: Richard W.M. Jones