Re: [Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2015 at 02:12:54PM +0100, Marc-André Lureau wrote: > On Mon, Nov 30, 2015 at 2:09 PM, Michael S. Tsirkin wrote: > > On Mon, Nov 30, 2015 at 06:00:29AM -0500, Marc-André Lureau wrote: > >> > >> > >> - Original Message - > >> > On Fri, Nov 27, 2015 at 03:41:20PM +0100, marcan

Re: [Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread Marc-André Lureau
On Mon, Nov 30, 2015 at 2:09 PM, Michael S. Tsirkin wrote: > On Mon, Nov 30, 2015 at 06:00:29AM -0500, Marc-André Lureau wrote: >> >> >> - Original Message - >> > On Fri, Nov 27, 2015 at 03:41:20PM +0100, marcandre.lur...@redhat.com >> > wrote: >> > > From: Marc-André Lureau >> > > >> >

Re: [Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2015 at 06:00:29AM -0500, Marc-André Lureau wrote: > > > - Original Message - > > On Fri, Nov 27, 2015 at 03:41:20PM +0100, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > The prepare callback needs to be implemented with glib < 2.36. > > >

Re: [Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread Marc-André Lureau
On Mon, Nov 30, 2015 at 12:00 PM, Marc-André Lureau wrote: > I don't follow what is the mess here. Ah ok, I get it, I forgot the #else NULL. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread Marc-André Lureau
- Original Message - > On Fri, Nov 27, 2015 at 03:41:20PM +0100, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The prepare callback needs to be implemented with glib < 2.36. > > > > Signed-off-by: Marc-André Lureau > > But nothing prevents us from implementin

Re: [Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread Michael S. Tsirkin
On Fri, Nov 27, 2015 at 03:41:20PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The prepare callback needs to be implemented with glib < 2.36. > > Signed-off-by: Marc-André Lureau But nothing prevents us from implementing it for all versions. > --- > tests/vhost-u

[Qemu-devel] [PATCH for-2.5 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-27 Thread marcandre . lureau
From: Marc-André Lureau The prepare callback needs to be implemented with glib < 2.36. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 29205ed.