Re: [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx

2015-08-12 Thread Richard Henderson
On 08/12/2015 05:11 PM, Laurent Vivier wrote: Le 12/08/2015 20:46, Richard Henderson a écrit : On 08/09/2015 01:13 PM, Laurent Vivier wrote: +return (op1 & ~((1UL << bits) - 1)) | res; \ deposit32(op1, res, bits, 0) You mean: deposit32(op1, 0, bits, res) ? Yes, sorry. The operand

Re: [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx

2015-08-12 Thread Laurent Vivier
Le 12/08/2015 20:46, Richard Henderson a écrit : > On 08/09/2015 01:13 PM, Laurent Vivier wrote: >> +return (op1 & ~((1UL << bits) - 1)) | res; \ > > deposit32(op1, res, bits, 0) > You mean: deposit32(op1, 0, bits, res) ? Laurent

Re: [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: > +return (op1 & ~((1UL << bits) - 1)) | res; \ deposit32(op1, res, bits, 0) Otherwise, Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx

2015-08-09 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/helper.c| 96 ++--- target-m68k/helper.h| 8 ++- target-m68k/translate.c | 141 3 files changed, 192 insertions(+), 53 deletions(-) diff --git a/target-m68k/helpe