Re: [Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers

2015-08-13 Thread Michael S. Tsirkin
On Wed, Jul 29, 2015 at 02:22:47PM +0200, Cornelia Huck wrote: > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > feature checking helpers") introduced a helper __virtio_has_feature. > We don't want to use reserved identifiers, though, so let's > rename __virtio_has_feature to virtio

Re: [Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers

2015-07-29 Thread Thomas Huth
On Wednesday, July 29, 2015 2:22:47 PM, "Cornelia Huck" wrote: > > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > feature checking helpers") introduced a helper __virtio_has_feature. > We don't want to use reserved identifiers, though, so let's > rename __virtio_has_feature to vi

Re: [Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers

2015-07-29 Thread Cornelia Huck
On Wed, 29 Jul 2015 08:43:08 -0400 (EDT) Thomas Huth wrote: > On Wednesday, July 29, 2015 2:22:47 PM, "Cornelia Huck" > wrote: > > > > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > > feature checking helpers") introduced a helper __virtio_has_feature. > > We don't want to use

[Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers

2015-07-29 Thread Cornelia Huck
Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add feature checking helpers") introduced a helper __virtio_has_feature. We don't want to use reserved identifiers, though, so let's rename __virtio_has_feature to virtio_has_feature and virtio_has_feature to virtio_vdev_has_feature. Signed