Re: [Qemu-devel] [PATCH for-2.5] bt: avoid unintended sign extension

2015-11-29 Thread Michael Tokarev
27.11.2015 15:08, Paolo Bonzini wrote: > In the case of a 4-byte length, shifting a value by 24 may cause > an unintended sign extension when converting from int to size_t. > Use a uint32_t variable instead. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH for-2.5] bt: avoid unintended sign extension

2015-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > In the case of a 4-byte length, shifting a value by 24 may cause > an unintended sign extension when converting from int to size_t. > Use a uint32_t variable instead. > > Signed-off-by: Paolo Bonzini For 32 bit ssize_t, lengths > 0x7fff go to negative, same as before

[Qemu-devel] [PATCH for-2.5] bt: avoid unintended sign extension

2015-11-27 Thread Paolo Bonzini
In the case of a 4-byte length, shifting a value by 24 may cause an unintended sign extension when converting from int to size_t. Use a uint32_t variable instead. Signed-off-by: Paolo Bonzini --- hw/bt/sdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/bt/sdp.c b/hw/bt/