Re: [Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty

2018-04-03 Thread Richard W.M. Jones
On Wed, Mar 28, 2018 at 10:22:31AM +0800, Richard Henderson wrote: > Since it was my patch that broke FP state tracking in the > first place, I feel obligated to fix it again. I missed this patch, thanks Michael Clark for pointing it out to me. I've just tried it now using my test reproducer of t

Re: [Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty

2018-03-28 Thread Michael Clark
On Tue, Mar 27, 2018 at 7:22 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > Since it was my patch that broke FP state tracking in the > first place, I feel obligated to fix it again. > > Mark mstatus[fs] as dirty whenever we write to the file. > This can be optimized by only doing

Re: [Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty

2018-03-27 Thread Michael Clark
Hi Richard, Thanks! I'll test this tomorrow morning and we can choose whether to include your proper fix or the workaround. I think we have time assuming we send out PRs tomorrow. Given our important fixes have review including either this fix by tomorrow or the workaround, and Philippe has revi

[Qemu-devel] [PATCH for-2.12 0/2] RISC-V: Mark FP status dirty

2018-03-27 Thread Richard Henderson
Since it was my patch that broke FP state tracking in the first place, I feel obligated to fix it again. Mark mstatus[fs] as dirty whenever we write to the file. This can be optimized by only doing so once within a TB which initially began with a clean file. I have not yet put together an environ